Fix Python SyntaxWarning in two f-string literals. #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voltur01
approved these changes
Oct 28, 2024
ostannard
approved these changes
Oct 28, 2024
Collaborator
ostannard
left a comment
ostannard
left a comment
There was a problem hiding this comment.
LGTM. Github made this confusing by removing some of the backslashes in the PR summary, you'll probably need to re-add them before merging.
Building on Ubuntu 24.04, multilib-generate.py provokes some SyntaxWarning messages from Python 3.12, because of cases where we'd written `\+` in a string, intended to be emitted literally. 3.12 still _does_ emit it literally, but prints a warning pointing out that we should properly escape the backslash, writing it as `\\+`.
statham-arm
force-pushed
the
python-syntaxwarning
branch
from
fce8d6b to
c15915f
Compare
Collaborator
Author
|
Or rather, use backticks so that it will look sensible whether you read the commit message as Markdown or as plain text. I don't want to force people to look at commits on the website! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on Ubuntu 24.04, multilib-generate.py provokes some SyntaxWarning messages from Python 3.12, because of cases where we'd written
\+in a string, intended to be emitted literally. 3.12 still does emit it literally, but prints a warning pointing out that we should properly escape the backslash, writing it as\\+.